Merged
Conversation
Greptile OverviewGreptile SummaryChanged the Key Issues:
Recommendation: Create a dedicated Confidence Score: 3/5
|
| Filename | Overview |
|---|---|
| src/cortex-core/src/style.rs | Changed system_message() style from muted gray to error red - affects all system messages including both errors and informational messages |
Sequence Diagram
sequenceDiagram
participant User
participant TUI as Cortex TUI
participant EventLoop
participant AppState
participant StyleRS as style.rs
participant ChatWidget as Chat Widget
User->>TUI: Executes command/triggers error
TUI->>EventLoop: Process command/error
alt Error condition
EventLoop->>EventLoop: add_system_message("Error: ...")
else Informational message
EventLoop->>EventLoop: add_system_message("Info message")
end
EventLoop->>AppState: add_message(Message::system(content))
AppState->>ChatWidget: Render message
ChatWidget->>StyleRS: Get style via CortexStyle::system_message()
alt Before this PR
StyleRS-->>ChatWidget: Returns TEXT_MUTED (gray #486581)
else After this PR
StyleRS-->>ChatWidget: Returns ERROR (red #FF6B6B)
end
ChatWidget->>User: Display message in styled color
src/cortex-core/src/style.rs
Outdated
Comment on lines
365
to
371
| /// System message style: error red italic text for backend error messages | ||
| #[inline] | ||
| pub fn system_message() -> Style { | ||
| Style::default() | ||
| .fg(TEXT_MUTED) | ||
| .fg(ERROR) | ||
| .add_modifier(Modifier::ITALIC) | ||
| } |
There was a problem hiding this comment.
system_message() is used for both errors AND informational messages (e.g., "Resumed session: {id}", command output). Making all system messages red misleads users into thinking informational messages are errors.
Consider creating a separate error_message() style as the PR description suggests, or distinguish message types at the call site.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/cortex-core/src/style.rs
Line: 365:371
Comment:
`system_message()` is used for both errors AND informational messages (e.g., "Resumed session: {id}", command output). Making all system messages red misleads users into thinking informational messages are errors.
Consider creating a separate `error_message()` style as the PR description suggests, or distinguish message types at the call site.
<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>
How can I resolve this? If you propose a fix, please make it concise.de17bae to
339ce15
Compare
Address Greptile review feedback on PR #18: - Reverted system_message() to use TEXT_MUTED (gray) for informational messages - Added new error_message() style with ERROR (red) + italic for backend errors - Rendering logic in rendering.rs already detects errors and uses colors.error This ensures regular system messages (like 'Resumed session') stay muted gray while actual error messages are displayed in red.
lahcenelhadi2001-a11y
pushed a commit
to lahcenelhadi2001-a11y/cortex
that referenced
this pull request
Mar 9, 2026
fix: make settings dialog sidebar responsive at narrow widths (fixes PlatformNetwork/bounty-challenge#21903)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
system_message()style incortex-core/src/style.rsTEXT_MUTED(gray #486581) toERROR(red #FF6B6B)Visual Impact
All system messages (including backend errors) will now appear in red with italic styling.